Skip to content

Minor internal API cleanups in date #20765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndossche merged 2 commits into from
Jan 13, 2026
Merged

Minor internal API cleanups in date #20765

ndossche merged 2 commits into from
Jan 13, 2026
+31 −31

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Dec 22, 2025

No description provided.

@ndossche
date: Remove unused argument for internal functions
7419b57
@ndossche
date: Avoid passing objects using double pointers
012cb59 
Using single pointers is cleaner and also generates better machine code.
@ndossche ndossche marked this pull request as ready for review December 23, 2025 10:00
@ndossche ndossche requested a review from derickr as a code owner December 23, 2025 10:00
derickr
derickr approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndossche ndossche merged commit d86182f into php:master Jan 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derickr derickr derickr approved these changes

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndossche @derickr @Girgias